godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-05 12:10:55 +00:00
Code Releases Wiki Activity

Fix Range's "changed" signal emitting with a value even if binded to emit none

Browse Source
This commit is contained in:
Michael Alexsander Silva Dias
2019-06-16 12:00:49 -03:00
parent 9c7cce3c9b
commit 98d0c99652
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scene/gui/range.cpp
View File

@@ -63,7 +63,7 @@ void Range::Shared::emit_value_changed() {
void Range::_changed_notify(const char *p_what) { void Range::_changed_notify(const char *p_what) {
emit_signal("changed", shared->val); emit_signal("changed");
update(); update();
_change_notify(p_what); _change_notify(p_what);
} }
@@ -79,6 +79,7 @@ void Range::Shared::emit_changed(const char *p_what) {
} }
void Range::set_value(double p_val) { void Range::set_value(double p_val) {
if (shared->step > 0) if (shared->step > 0)
p_val = Math::round(p_val / shared->step) * shared->step; p_val = Math::round(p_val / shared->step) * shared->step;
@@ -303,22 +304,27 @@ bool Range::is_ratio_exp() const {
} }
void Range::set_allow_greater(bool p_allow) { void Range::set_allow_greater(bool p_allow) {
shared->allow_greater = p_allow; shared->allow_greater = p_allow;
} }
bool Range::is_greater_allowed() const { bool Range::is_greater_allowed() const {
return shared->allow_greater; return shared->allow_greater;
} }
void Range::set_allow_lesser(bool p_allow) { void Range::set_allow_lesser(bool p_allow) {
shared->allow_lesser = p_allow; shared->allow_lesser = p_allow;
} }
bool Range::is_lesser_allowed() const { bool Range::is_lesser_allowed() const {
return shared->allow_lesser; return shared->allow_lesser;
} }
Range::Range() { Range::Range() {
shared = memnew(Shared); shared = memnew(Shared);
shared->min = 0; shared->min = 0;
shared->max = 100; shared->max = 100;