godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-15 13:51:40 +00:00
Code Releases Wiki Activity

Profiling - fix frame_time measurement

Browse Source 
When the `sync_after_draw` feature was on it was possible for the profiler's frame_time measurement to be incorrect. This fixes this problem by storing the raw measured time for use by the profiler.
This commit is contained in:
lawnjelly
2021-08-01 10:05:43 +01:00
parent a17228c788
commit 98a39aade9
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
main/main.cpp
View File

@@ -2056,17 +2056,20 @@ bool Main::iteration() {
iterating++; iterating++;
// ticks may become modified later on, and we want to store the raw measured
// value for profiling.
uint64_t raw_ticks_at_start = OS::get_singleton()->get_ticks_usec();
#ifdef TOOLS_ENABLED #ifdef TOOLS_ENABLED
uint64_t ticks = OS::get_singleton()->get_ticks_usec(); uint64_t ticks = raw_ticks_at_start;
#else #else
// we can either sync the delta from here, or later in the iteration // we can either sync the delta from here, or later in the iteration
uint64_t ticks_at_start = OS::get_singleton()->get_ticks_usec(); uint64_t ticks_difference = raw_ticks_at_start - frame_delta_sync_time;
uint64_t ticks_difference = ticks_at_start - frame_delta_sync_time;
// if we are syncing at start or if frame_delta_sync_time is being initialized // if we are syncing at start or if frame_delta_sync_time is being initialized
// or a large gap has happened between the last delta_sync_time and now // or a large gap has happened between the last delta_sync_time and now
if (!delta_sync_after_draw || (ticks_difference > 100000)) { if (!delta_sync_after_draw || (ticks_difference > 100000)) {
frame_delta_sync_time = ticks_at_start; frame_delta_sync_time = raw_ticks_at_start;
} }
uint64_t ticks = frame_delta_sync_time; uint64_t ticks = frame_delta_sync_time;
#endif #endif
@@ -2165,9 +2168,10 @@ bool Main::iteration() {
} }
#endif #endif
// profiler timing information
idle_process_ticks = OS::get_singleton()->get_ticks_usec() - idle_begin; idle_process_ticks = OS::get_singleton()->get_ticks_usec() - idle_begin;
idle_process_max = MAX(idle_process_ticks, idle_process_max); idle_process_max = MAX(idle_process_ticks, idle_process_max);
uint64_t frame_time = OS::get_singleton()->get_ticks_usec() - ticks; uint64_t frame_time = OS::get_singleton()->get_ticks_usec() - raw_ticks_at_start;
for (int i = 0; i < ScriptServer::get_language_count(); i++) { for (int i = 0; i < ScriptServer::get_language_count(); i++) {
ScriptServer::get_language(i)->frame(); ScriptServer::get_language(i)->frame();