From 9419ef2f3409b9ee86e3bc51fad8a7d47f3b3323 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Wed, 7 May 2025 23:21:51 +0200 Subject: [PATCH] basis_universal: Add missing `ctype.h` include to fix MSVC build Seems like latest MSVC tweaked some headers and we no longer have definitions for `isdigit` and `isalpha` without an explicit include. --- thirdparty/README.md | 2 ++ .../patches/0005-msvc-include-ctype.patch | 13 +++++++++++++ .../transcoder/basisu_containers_impl.h | 2 ++ 3 files changed, 17 insertions(+) create mode 100644 thirdparty/basis_universal/patches/0005-msvc-include-ctype.patch diff --git a/thirdparty/README.md b/thirdparty/README.md index 8e2483a8c66..244cb70f6c3 100644 --- a/thirdparty/README.md +++ b/thirdparty/README.md @@ -89,6 +89,8 @@ Patches: - `0002-external-tinyexr.patch` (GH-97582) - `0003-remove-tinydds-qoi.patch` (GH-97582) - `0004-ambiguous-calls.patch` (GH-103968) +- `0005-msvc-include-ctype.patch` (GH-106155) + ## brotli diff --git a/thirdparty/basis_universal/patches/0005-msvc-include-ctype.patch b/thirdparty/basis_universal/patches/0005-msvc-include-ctype.patch new file mode 100644 index 00000000000..3a38950bbcc --- /dev/null +++ b/thirdparty/basis_universal/patches/0005-msvc-include-ctype.patch @@ -0,0 +1,13 @@ +diff --git a/thirdparty/basis_universal/transcoder/basisu_containers_impl.h b/thirdparty/basis_universal/transcoder/basisu_containers_impl.h +index d4d3eb23bc..3d7aaddcad 100644 +--- a/thirdparty/basis_universal/transcoder/basisu_containers_impl.h ++++ b/thirdparty/basis_universal/transcoder/basisu_containers_impl.h +@@ -1,6 +1,8 @@ + // basisu_containers_impl.h + // Do not include directly + ++#include ++ + #ifdef _MSC_VER + #pragma warning (disable:4127) // warning C4127: conditional expression is constant + #endif diff --git a/thirdparty/basis_universal/transcoder/basisu_containers_impl.h b/thirdparty/basis_universal/transcoder/basisu_containers_impl.h index d4d3eb23bc0..3d7aaddcade 100644 --- a/thirdparty/basis_universal/transcoder/basisu_containers_impl.h +++ b/thirdparty/basis_universal/transcoder/basisu_containers_impl.h @@ -1,6 +1,8 @@ // basisu_containers_impl.h // Do not include directly +#include + #ifdef _MSC_VER #pragma warning (disable:4127) // warning C4127: conditional expression is constant #endif