godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-05 17:15:09 +00:00
Code Releases Wiki Activity

Disable threading in Asset Library

Browse Source 
Threaded HTTPRequest appears to be crashy on 3.0.x.
Fixes #19336.
This commit is contained in:
Rémi Verschelde
2018-06-22 09:30:17 +02:00
parent 4d7aa0b762
commit 909eaede4c
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
editor/plugins/asset_library_editor_plugin.cpp
View File

@@ -515,7 +515,8 @@ EditorAssetLibraryItemDownload::EditorAssetLibraryItemDownload() {
download = memnew(HTTPRequest);
add_child(download);
download->connect("request_completed", this, "_http_download_completed");
download->set_use_threads(EDITOR_DEF("asset_library/use_threads", true));
// Threaded HTTPRequest causes crashes (GH-19336)
download->set_use_threads(false);
download_error = memnew(AcceptDialog);
add_child(download_error);
@@ -834,7 +835,8 @@ void EditorAssetLibrary::_request_image(ObjectID p_for, String p_image_url, Imag
iq.image_index = p_image_index;
iq.image_type = p_type;
iq.request = memnew(HTTPRequest);
iq.request->set_use_threads(EDITOR_DEF("asset_library/use_threads", true));
// Threaded HTTPRequest causes crashes (GH-19336)
iq.request->set_use_threads(false);
iq.target = p_for;
iq.queue_id = ++last_queue_id;