godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-06 17:25:19 +00:00
Code Releases Wiki Activity

[Core] Fix Variant::construct of Object

Browse Source 
Variant type was not updated correctly causing leaks in ref-counted
This commit is contained in:
A Thousand Ships
2024-04-02 15:49:56 +02:00
parent e343dbbcc1
commit 8f3e2c96eb
5 changed files with 34 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
modules/gdscript/tests/scripts/runtime/errors/invalid_property_assignment.gd Normal file
View File

@@ -0,0 +1,9 @@
# https://github.com/godotengine/godot/issues/90086
class MyObj:
var obj: WeakRef
func test():
var obj_1 = MyObj.new()
var obj_2 = MyObj.new()
obj_1.obj = obj_2

6
modules/gdscript/tests/scripts/runtime/errors/invalid_property_assignment.out Normal file
View File

@@ -0,0 +1,6 @@
GDTEST_RUNTIME_ERROR
>> SCRIPT ERROR
>> on function: test()
>> runtime/errors/invalid_property_assignment.gd
>> 9
>> Invalid assignment of property or key 'obj' with value of type 'RefCounted (MyObj)' on a base object of type 'RefCounted (MyObj)'.

11
modules/gdscript/tests/scripts/runtime/features/set_does_not_leak.gd Normal file
View File

@@ -0,0 +1,11 @@
# https://github.com/godotengine/godot/issues/90086
class MyObj:
var obj : WeakRef
func test():
var obj_1 = MyObj.new()
var obj_2 = MyObj.new()
assert(obj_2.get_reference_count() == 1)
obj_1.set(&"obj", obj_2)
assert(obj_2.get_reference_count() == 1)

1
modules/gdscript/tests/scripts/runtime/features/set_does_not_leak.out Normal file
View File

@@ -0,0 +1 @@
GDTEST_OK