godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Merge pull request #107936 from mihe/missing-await-warning

Browse Source 
Add opt-in GDScript warning for when calling coroutine without `await`
This commit is contained in:
Thaddeus Crews
2025-09-30 18:35:05 -05:00
parent 4c3765d9ff a3e58a385f
commit 8bc1dd63f4
8 changed files with 29 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/gdscript/gdscript_analyzer.cpp
View File

@@ -3758,8 +3758,14 @@ void GDScriptAnalyzer::reduce_call(GDScriptParser::CallNode *p_call, bool p_is_a
}
}
if (call_type.is_coroutine && !p_is_await && !p_is_root) {
push_error(vformat(R"*(Function "%s()" is a coroutine, so it must be called with "await".)*", p_call->function_name), p_call);
if (call_type.is_coroutine && !p_is_await) {
if (p_is_root) {
#ifdef DEBUG_ENABLED
parser->push_warning(p_call, GDScriptWarning::MISSING_AWAIT);
#endif // DEBUG_ENABLED
} else {
push_error(vformat(R"*(Function "%s()" is a coroutine, so it must be called with "await".)*", p_call->function_name), p_call);
}
}
p_call->set_datatype(call_type);