godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-10 13:00:37 +00:00
Code Releases Wiki Activity

Fix extra separator in filesystem dock right click menu

Browse Source 
Re-order add_separator calls to stop adding an extra separator if no item was selected.
It is possible for no items to be selected by right clicking the ".." item.
This commit is contained in:
MillionOstrich
2017-11-20 23:45:26 +00:00
parent d11a61962f
commit 89f264c4a8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
editor/filesystem_dock.cpp
View File

@@ -1417,17 +1417,17 @@ void FileSystemDock::_files_list_rmb_select(int p_item, const Vector2 &p_pos) {
if (all_files_scenes) { if (all_files_scenes) {
file_options->add_item(TTR("Instance"), FILE_INSTANCE); file_options->add_item(TTR("Instance"), FILE_INSTANCE);
} }
file_options->add_separator();
if (filenames.size() == 1) { if (filenames.size() == 1) {
file_options->add_separator();
file_options->add_item(TTR("Edit Dependencies.."), FILE_DEPENDENCIES); file_options->add_item(TTR("Edit Dependencies.."), FILE_DEPENDENCIES);
file_options->add_item(TTR("View Owners.."), FILE_OWNERS); file_options->add_item(TTR("View Owners.."), FILE_OWNERS);
file_options->add_separator();
} }
} else if (all_folders && foldernames.size() > 0) { } else if (all_folders && foldernames.size() > 0) {
file_options->add_item(TTR("Open"), FILE_OPEN); file_options->add_item(TTR("Open"), FILE_OPEN);
}
file_options->add_separator(); file_options->add_separator();
}
int num_items = filenames.size() + foldernames.size(); int num_items = filenames.size() + foldernames.size();
if (num_items >= 1) { if (num_items >= 1) {