godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-17 14:11:06 +00:00
Code Releases Wiki Activity

Duplicate DynamicFontData resources in the editor preview generation thread to avoid race condition.

Browse Source 
(cherry picked from commit 301bedd5d4)
This commit is contained in:
bruvzg
2021-04-29 23:27:52 +03:00
committed by Rémi Verschelde
parent edf5a03714
commit 87aa694ae5
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
editor/plugins/editor_preview_plugins.cpp
View File

@@ -838,14 +838,15 @@ Ref<Texture> EditorFontPreviewPlugin::generate_from_path(const String &p_path, c
ril.ptr()->wait();
RES res = ril.ptr()->get_resource();
Ref<DynamicFont> sampled_font;
sampled_font.instance();
if (res->is_class("DynamicFont")) {
sampled_font = res->duplicate();
if (sampled_font->get_outline_color() == Color(1, 1, 1, 1)) {
sampled_font->set_outline_color(Color(0, 0, 0, 1));
Ref<DynamicFont> font = res;
sampled_font->set_font_data(font->get_font_data()->duplicate());
for (int i = 0; i < font->get_fallback_count(); i++) {
sampled_font->add_fallback(font->get_fallback(i)->duplicate());
}
} else if (res->is_class("DynamicFontData")) {
sampled_font.instance();
sampled_font->set_font_data(res);
sampled_font->set_font_data(res->duplicate());
}
sampled_font->set_size(50);