godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

SCons: Re-enable treating #warning as error with werror

Browse Source 
Replace all TODO uses of `#warning` by proper TODO comments, and will open
matching bug reports to keep track of them.

We don't have a great track record fixing TODOs, but I'd wager we're even
worse for fixing these "TODO #warning" so we should prohibit this usage.
This commit is contained in:
Rémi Verschelde
2022-10-10 13:04:01 +02:00
parent 4e4e16f9a9
commit 8017827144
24 changed files with 32 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
platform/android/api/jni_singleton.h
View File

@@ -150,9 +150,8 @@ public:
env->DeleteLocalRef(arr);
} break;
#ifndef _MSC_VER
#warning This is missing 64 bits arrays, I have no idea how to do it in JNI
#endif
// TODO: This is missing 64 bits arrays, I have no idea how to do it in JNI.
case Variant::DICTIONARY: {
jobject obj = env->CallObjectMethodA(instance, E->get().method, v);
ret = _jobject_to_variant(env, obj);