godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Don't return reference on copy assignment operators

Browse Source 
We prefer to prevent using chained assignment (`T a = b = c = T();`) as this
can lead to confusing code and subtle bugs.

According to https://en.wikipedia.org/wiki/Assignment_operator_(C%2B%2B), C++
allows any arbitrary return type, so this is standard compliant.

This could be re-assessed if/when we have an actual need for a behavior more
akin to that of the C++ STL, for now this PR simply changes a handful of
cases which were inconsistent with the rest of the codebase (`void` return
type was already the most common case prior to this commit).
This commit is contained in:
Rémi Verschelde
2021-11-30 15:19:26 +01:00
parent 2d118bd8b8
commit 7da392bcc5
28 changed files with 93 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/gdscript/gdscript_parser.h
View File

@@ -203,7 +203,7 @@ public:
return !(this->operator==(p_other));
}
DataType &operator=(const DataType &p_other) {
void operator=(const DataType &p_other) {
kind = p_other.kind;
type_source = p_other.type_source;
is_constant = p_other.is_constant;
@@ -221,7 +221,6 @@ public:
if (p_other.has_container_element_type()) {
set_container_element_type(p_other.get_container_element_type());
}
return *this;
}
DataType() = default;