godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-16 14:00:40 +00:00
Code Releases Wiki Activity

Make sure marked nodes are reset on scene change

Browse Source 
The performance improvement on the SceneTreeEditor caused the previous
state of the SceneTreeEditor::marked HashSet to matter, when it
previously was always just overwritten when markings changed. The old
code thus had no reason to ever clear the marking list.

We now make sure that whether the SceneTreeEditor is hidden or not that
when the edited scene changes we always reset the entire state of the
editor, including the marked HashSet.
This commit is contained in:
HP van Braam
2025-01-05 01:56:42 +01:00
parent bdf625bd54
commit 7ce9c339b3
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
editor/gui/scene_tree_editor.cpp
View File

@@ -892,6 +892,15 @@ void SceneTreeEditor::_update_tree(bool p_scroll_to_selected) {
return;
}
Node *scene_node = get_scene_node();
if (node_cache.current_scene_node != scene_node) {
_reset();
marked.clear();
node_cache.current_scene_node = scene_node;
node_cache.force_update = true;
}
if (!update_when_invisible && !is_visible_in_tree()) {
return;
}
@@ -903,13 +912,6 @@ void SceneTreeEditor::_update_tree(bool p_scroll_to_selected) {
updating_tree = true;
last_hash = hash_djb2_one_64(0);
Node *scene_node = get_scene_node();
if (node_cache.current_scene_node != scene_node) {
_reset();
node_cache.current_scene_node = scene_node;
node_cache.force_update = true;
}
if (node_cache.current_scene_node) {
// Handle pinning/unpinning the animation player only do this once per iteration.