godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-12 13:20:55 +00:00
Code Releases Wiki Activity

Merge pull request #56830 from strank/parent-signals

Browse Source
This commit is contained in:
Rémi Verschelde
2022-03-04 17:29:49 +01:00
committed by GitHub
parent bb8c4acdc9 dcf19f8914
commit 79bbe57244
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
modules/gdscript/gdscript_compiler.cpp
View File

@@ -294,16 +294,21 @@ GDScriptCodeGenerator::Address GDScriptCompiler::_parse_expression(CodeGen &code
// Try signals and methods (can be made callables). // Try signals and methods (can be made callables).
{ {
if (codegen.class_node->members_indices.has(identifier)) { // Search upwards through parent classes:
const GDScriptParser::ClassNode::Member &member = codegen.class_node->members[codegen.class_node->members_indices[identifier]]; const GDScriptParser::ClassNode *base_class = codegen.class_node;
if (member.type == GDScriptParser::ClassNode::Member::FUNCTION || member.type == GDScriptParser::ClassNode::Member::SIGNAL) { while (base_class != nullptr) {
// Get like it was a property. if (base_class->has_member(identifier)) {
GDScriptCodeGenerator::Address temp = codegen.add_temporary(); // TODO: Get type here. const GDScriptParser::ClassNode::Member &member = base_class->get_member(identifier);
GDScriptCodeGenerator::Address self(GDScriptCodeGenerator::Address::SELF); if (member.type == GDScriptParser::ClassNode::Member::FUNCTION || member.type == GDScriptParser::ClassNode::Member::SIGNAL) {
// Get like it was a property.
GDScriptCodeGenerator::Address temp = codegen.add_temporary(); // TODO: Get type here.
GDScriptCodeGenerator::Address self(GDScriptCodeGenerator::Address::SELF);
gen->write_get_named(temp, identifier, self); gen->write_get_named(temp, identifier, self);
return temp; return temp;
}
} }
base_class = base_class->base_type.class_type;
} }
// Try in native base. // Try in native base.