godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Merge pull request #104556 from Ivorforce/string-extend-instead-of-parse

Browse Source 
Use `append_` instead of `parse_` for `String` methods.
This commit is contained in:
Thaddeus Crews
2025-03-29 10:16:33 -05:00
parent 6bab3c07fc ffa6ef220b
commit 780cf03051
62 changed files with 245 additions and 274 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/unix/os_unix.cpp
View File

@@ -830,7 +830,7 @@ Error OS_Unix::execute(const String &p_path, const List<String> &p_arguments, St
p_pipe_mutex->lock();
}
String pipe_out;
if (pipe_out.parse_utf8(buf) == OK) {
if (pipe_out.append_utf8(buf) == OK) {
(*r_pipe) += pipe_out;
} else {
(*r_pipe) += String(buf); // If not valid UTF-8 try decode as Latin-1
@@ -1062,7 +1062,7 @@ String OS_Unix::get_environment(const String &p_var) const {
return "";
}
String s;
if (s.parse_utf8(val) == OK) {
if (s.append_utf8(val) == OK) {
return s;
}
return String(val); // Not valid UTF-8, so return as-is
@@ -1091,7 +1091,7 @@ String OS_Unix::get_executable_path() const {
ssize_t len = readlink("/proc/self/exe", buf, sizeof(buf));
String b;
if (len > 0) {
b.parse_utf8(buf, len);
b.append_utf8(buf, len);
}
if (b.is_empty()) {
WARN_PRINT("Couldn't get executable path from /proc/self/exe, using argv[0]");
@@ -1128,7 +1128,7 @@ String OS_Unix::get_executable_path() const {
return OS::get_executable_path();
}
String b;
b.parse_utf8(buf);
b.append_utf8(buf);
return b;
#elif defined(__APPLE__)
char temp_path[1];