godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-05 12:10:55 +00:00
Code Releases Wiki Activity

C#: Ignore property indexers and report if exported

Browse Source 
Ignore property indexers since they are unsupported and report a
diagnostic if an user tries to export it.
This commit is contained in:
Raul Santos
2022-08-28 18:16:57 +02:00
parent f38ea254f3
commit 761e2b1a65
4 changed files with 36 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/ScriptPropertyDefValGenerator.cs
View File

@@ -134,6 +134,12 @@ namespace Godot.SourceGenerators
continue;
}
if (property.IsIndexer)
{
Common.ReportExportedMemberIsIndexer(context, property);
continue;
}
// TODO: We should still restore read-only properties after reloading assembly. Two possible ways: reflection or turn RestoreGodotObjectData into a constructor overload.
// Ignore properties without a getter or without a setter. Godot properties must be both readable and writable.
if (property.IsWriteOnly)
@@ -148,7 +154,6 @@ namespace Godot.SourceGenerators
continue;
}
var propertyType = property.Type;
var marshalType = MarshalUtils.ConvertManagedTypeToMarshalType(propertyType, typeCache);