godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-19 14:31:59 +00:00
Code Releases Wiki Activity

Removed unnecessary assignments

Browse Source
This commit is contained in:
Wilson E. Alvarez
2017-08-21 15:15:36 -04:00
parent 4717d37bfa
commit 738d2ab969
37 changed files with 65 additions and 128 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/pbm/bitmap_loader_pbm.cpp
View File

@@ -95,6 +95,9 @@ static bool _get_token(FileAccessRef &f, uint8_t &saved, PoolVector<uint8_t> &r_
resized = true;
}
if (resized) {
// Note: Certain C++ static analyzers might point out that the following assigment is unnecessary.
// This is wrong since PoolVector<class T>::Write has an operator= method where the lhs gets updated under certain conditions.
// See core/dvector.h.
w = PoolVector<uint8_t>::Write();
r_token.resize(token_max);
w = r_token.write();