godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-09 12:50:35 +00:00
Code Releases Wiki Activity

Fix JavaScript callback memory leak issue

Browse Source 
Typo fix
This commit is contained in:
SysError99
2023-08-29 13:57:44 +07:00
parent 541674d106
commit 6a90164a03
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
platform/web/js/libs/library_godot_javascript_singleton.js
View File

@@ -210,7 +210,9 @@ const GodotJSWrapper = {
// This is safe! JavaScript is single threaded (and using it in threads is not a good idea anyway). // This is safe! JavaScript is single threaded (and using it in threads is not a good idea anyway).
GodotJSWrapper.cb_ret = null; GodotJSWrapper.cb_ret = null;
const args = Array.from(arguments); const args = Array.from(arguments);
func(p_ref, GodotJSWrapper.get_proxied(args), args.length); const argsProxy = GodotJSWrapper.MyProxy(args);
func(p_ref, argsProxy.get_id(), args.length);
argsProxy.unref();
const ret = GodotJSWrapper.cb_ret; const ret = GodotJSWrapper.cb_ret;
GodotJSWrapper.cb_ret = null; GodotJSWrapper.cb_ret = null;
return ret; return ret;