godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-22 15:06:45 +00:00
Code Releases Wiki Activity

Revert "Emit signal when animation ends by seek"

Browse Source 
This reverts commit bf1cc116e1.

This needs more discussion to avoid breaking some users' expectations.
See #38086 for arguments.
This commit is contained in:
Rémi Verschelde
2020-05-04 16:09:19 +02:00
parent a6d83f7f3d
commit 69f36cea8c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scene/animation/animation_player.cpp
View File

@@ -950,13 +950,13 @@ void AnimationPlayer::_animation_process(float p_delta) {
play(queued.front()->get()); play(queued.front()->get());
String new_name = playback.assigned; String new_name = playback.assigned;
queued.pop_front(); queued.pop_front();
if (end_notify || playback.seeked) if (end_notify)
emit_signal(SceneStringNames::get_singleton()->animation_changed, old, new_name); emit_signal(SceneStringNames::get_singleton()->animation_changed, old, new_name);
} else { } else {
//stop(); //stop();
playing = false; playing = false;
_set_process(false); _set_process(false);
if (end_notify || playback.seeked) if (end_notify)
emit_signal(SceneStringNames::get_singleton()->animation_finished, playback.assigned); emit_signal(SceneStringNames::get_singleton()->animation_finished, playback.assigned);
} }
end_reached = false; end_reached = false;