godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-13 13:31:48 +00:00
Code Releases Wiki Activity

Add missing ERR_FAIL_INDEX check to Variant::construct

Browse Source 
Other functions in the same file validate parameters using the ERR_FAIL
macros. This validation was missing for Variant::construct resulting in
a crash when called with invalid data (p_type < 0).

fix #46067
This commit is contained in:
Alex Hirsch
2021-03-04 18:44:30 +01:00
parent 4c10d31bc4
commit 6985967c3b
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
core/variant/variant_construct.cpp
View File

@@ -773,6 +773,7 @@ void Variant::_unregister_variant_constructors() {
} }
void Variant::construct(Variant::Type p_type, Variant &base, const Variant **p_args, int p_argcount, Callable::CallError &r_error) { void Variant::construct(Variant::Type p_type, Variant &base, const Variant **p_args, int p_argcount, Callable::CallError &r_error) {
ERR_FAIL_INDEX(p_type, Variant::VARIANT_MAX);
uint32_t s = construct_data[p_type].size(); uint32_t s = construct_data[p_type].size();
for (uint32_t i = 0; i < s; i++) { for (uint32_t i = 0; i < s; i++) {
int argc = construct_data[p_type][i].argument_count; int argc = construct_data[p_type][i].argument_count;