godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-06 12:20:30 +00:00
Code Releases Wiki Activity

Merge pull request #40849 from jzulauf-lunarg/zulauf_buffer_update_err_msg

Browse Source 
Cause buffer_update to emit error if called during compute/draw list
This commit is contained in:
Juan Linietsky
2020-10-19 14:10:41 -03:00
committed by GitHub
parent f9918cbc0e 98d677ef26
commit 5f65eba5c4
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/vulkan/rendering_device_vulkan.cpp
View File

@@ -1542,6 +1542,10 @@ Error RenderingDeviceVulkan::_staging_buffer_allocate(uint32_t p_amount, uint32_
} }
Error RenderingDeviceVulkan::_buffer_update(Buffer *p_buffer, size_t p_offset, const uint8_t *p_data, size_t p_data_size, bool p_use_draw_command_buffer, uint32_t p_required_align) { Error RenderingDeviceVulkan::_buffer_update(Buffer *p_buffer, size_t p_offset, const uint8_t *p_data, size_t p_data_size, bool p_use_draw_command_buffer, uint32_t p_required_align) {
// Buffer update not valid during draw or compute lists
ERR_FAIL_COND_V_MSG(draw_list != nullptr, ERR_BUG, "Buffer update not valid when draw list is active.");
ERR_FAIL_COND_V_MSG(compute_list != nullptr, ERR_BUG, "Buffer update not valid when compute list is active.");
//submitting may get chunked for various reasons, so convert this to a task //submitting may get chunked for various reasons, so convert this to a task
size_t to_submit = p_data_size; size_t to_submit = p_data_size;
size_t submit_from = 0; size_t submit_from = 0;