godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-11 13:10:58 +00:00
Code Releases Wiki Activity

Fix heap-use-after-free when changing 2D editor selection

Browse Source
This commit is contained in:
Haoyu Qiu
2025-02-07 09:30:02 +08:00
parent 06acfccf89
commit 577f90feba
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
editor/plugins/canvas_item_editor_plugin.cpp
View File

@@ -3659,10 +3659,12 @@ void CanvasItemEditor::_draw_selection() {
} }
// Remove non-movable nodes. // Remove non-movable nodes.
for (CanvasItem *ci : selection) { for (List<CanvasItem *>::Element *E = selection.front(); E;) {
if (!_is_node_movable(ci)) { List<CanvasItem *>::Element *N = E->next();
selection.erase(ci); if (!_is_node_movable(E->get())) {
selection.erase(E);
} }
E = N;
} }
if (!selection.is_empty() && transform_tool && show_transformation_gizmos) { if (!selection.is_empty() && transform_tool && show_transformation_gizmos) {