godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-11 13:10:58 +00:00
Code Releases Wiki Activity

Fix heap-use-after-free when ctrl-clicking controls in a container

Browse Source
This commit is contained in:
Haoyu Qiu
2024-10-23 08:54:45 +08:00
parent 61accf0605
commit 574b413bef
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
editor/plugins/canvas_item_editor_plugin.cpp
View File

@@ -1464,10 +1464,12 @@ bool CanvasItemEditor::_gui_input_rotate(const Ref<InputEvent> &p_event) {
List<CanvasItem *> selection = _get_edited_canvas_items(false, true, &has_locked_items); List<CanvasItem *> selection = _get_edited_canvas_items(false, true, &has_locked_items);
// Remove not movable nodes // Remove not movable nodes
for (CanvasItem *E : selection) { for (List<CanvasItem *>::Element *E = selection.front(); E;) {
if (!_is_node_movable(E, true)) { List<CanvasItem *>::Element *N = E->next();
if (!_is_node_movable(E->get(), true)) {
selection.erase(E); selection.erase(E);
} }
E = N;
} }
drag_selection = selection; drag_selection = selection;