From 54c2eaee4daa4ca13a23cca500faa9249d9ec830 Mon Sep 17 00:00:00 2001 From: kobewi Date: Fri, 14 Nov 2025 18:52:42 +0100 Subject: [PATCH] Don't expose underscored signals --- editor/doc/doc_tools.cpp | 4 ++++ modules/gdscript/gdscript_editor.cpp | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/editor/doc/doc_tools.cpp b/editor/doc/doc_tools.cpp index 0166efec039..5bdd6390ce0 100644 --- a/editor/doc/doc_tools.cpp +++ b/editor/doc/doc_tools.cpp @@ -660,6 +660,10 @@ void DocTools::generate(BitField p_flags) { if (signal_list.size()) { for (const MethodInfo &mi : signal_list) { + if (mi.name.is_empty() || mi.name[0] == '_') { + continue; // Hidden, don't count. + } + DocData::MethodDoc signal; signal.name = mi.name; for (const PropertyInfo &arginfo : mi.arguments) { diff --git a/modules/gdscript/gdscript_editor.cpp b/modules/gdscript/gdscript_editor.cpp index 38f710ae1a8..6c065844755 100644 --- a/modules/gdscript/gdscript_editor.cpp +++ b/modules/gdscript/gdscript_editor.cpp @@ -1290,6 +1290,9 @@ static void _find_identifiers_in_base(const GDScriptCompletionIdentifier &p_base List signals; scr->get_script_signal_list(&signals); for (const MethodInfo &E : signals) { + if (E.name.begins_with("_")) { + continue; + } int location = p_recursion_depth + _get_signal_location(scr, E.name); ScriptLanguage::CodeCompletionOption option(E.name, ScriptLanguage::CODE_COMPLETION_KIND_SIGNAL, location); r_result.insert(option.display, option); @@ -1383,6 +1386,9 @@ static void _find_identifiers_in_base(const GDScriptCompletionIdentifier &p_base List signals; ClassDB::get_signal_list(type, &signals); for (const MethodInfo &E : signals) { + if (E.name.begins_with("_")) { + continue; + } int location = p_recursion_depth + _get_signal_location(type, StringName(E.name)); ScriptLanguage::CodeCompletionOption option(E.name, ScriptLanguage::CODE_COMPLETION_KIND_SIGNAL, location); r_result.insert(option.display, option);