godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-11 13:10:58 +00:00
Code Releases Wiki Activity

Add missing initializations for Node3DEditor.

Browse Source 
Do not try to format fields with garbage values in _snap_update()
Initialize grid_enable[] before use.
Initialize previewing_camera before use.
These are all cases found live, with valgrind.
Fixes #76925
This commit is contained in:
Bram Stolk
2023-05-10 13:23:55 -07:00
parent fd4a06c515
commit 4bc513edbc
2 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
editor/plugins/node_3d_editor_plugin.cpp
View File

@@ -8382,8 +8382,6 @@ Node3DEditor::Node3DEditor() {
snap_scale->set_select_all_on_focus(true);
snap_dialog_vbc->add_margin_child(TTR("Scale Snap (%):"), snap_scale);
_snap_update();
/* SETTINGS DIALOG */
settings_dialog = memnew(ConfirmationDialog);
@@ -8703,7 +8701,7 @@ void fragment() {
_load_default_preview_settings();
_preview_settings_changed();
}
clear(); // Make sure values are initialized.
clear(); // Make sure values are initialized. Will call _snap_update() for us.
}
Node3DEditor::~Node3DEditor() {
memdelete(preview_node);