godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-11 13:10:58 +00:00
Code Releases Wiki Activity

[Net] Simplify IP resolution code, fix caching.

Browse Source 
First, we should not insert into cache if the hostname resolution has
failed (as it might be a temporary internet issue), second, the async
resolver should also properly insert into cache.

Took the chance to remove some duplicate code with critical section in
it at the cost of little performance when calling the blocking
resolve_hostname function.
This commit is contained in:
Fabio Alessandrelli
2022-01-29 01:33:29 +01:00
parent 252ec22ff9
commit 49297d937c
2 changed files with 13 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/unix/ip_unix.cpp
View File

@@ -115,7 +115,7 @@ void IPUnix::_resolve_hostname(List<IPAddress> &r_addresses, const String &p_hos
continue;
}
IPAddress ip = _sockaddr2ip(next->ai_addr);
if (!r_addresses.find(ip)) {
if (ip.is_valid() && !r_addresses.find(ip)) {
r_addresses.push_back(ip);
}
next = next->ai_next;