godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-08 12:40:44 +00:00
Code Releases Wiki Activity

LocalVector: Don't error if from >= count

Browse Source 
Vector handles this silently by returning -1, and we should do the same here.
Otherwise we get errors when calling `find()` on e.g. a LocalVector of size 0,
while `find()` is expected to always work (if the parameters are invalid then
it doesn't find anything, so -1).

Fixup to #49925.

(cherry picked from commit 7b7ccf25b6)
This commit is contained in:
Rémi Verschelde
2021-07-01 12:16:26 +02:00
parent c43d33fa60
commit 47a0490ff3
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
core/local_vector.h
View File

@@ -178,7 +178,6 @@ public:
} }
int64_t find(const T &p_val, U p_from = 0) const { int64_t find(const T &p_val, U p_from = 0) const {
ERR_FAIL_UNSIGNED_INDEX_V(p_from, count, -1);
for (U i = p_from; i < count; i++) { for (U i = p_from; i < count; i++) {
if (data[i] == p_val) { if (data[i] == p_val) {
return int64_t(i); return int64_t(i);