godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-06 12:20:30 +00:00
Code Releases Wiki Activity

Fix incorrect failure code in screen_get_framebuffer_format

Browse Source 
RenderingDevice::screen_get_framebuffer_format should return a value of
type RenderingDevice::FramebufferFormatID which is an alias of int64_t
but it returns Error::FAILED with a value of 1. The compiler does not
complain because both types are integers but 1 corresponds to a valid
FramebufferFormatID, meaning a certain failure condition is missed.

This commit changes it to the correct value, INVALID_ID.
This commit is contained in:
Erik Ritschl
2025-10-21 15:26:26 +02:00
parent f50d7fa1e8
commit 44451e6988
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
servers/rendering/rendering_device.cpp
View File

@@ -4260,7 +4260,7 @@ RenderingDevice::FramebufferFormatID RenderingDevice::screen_get_framebuffer_for
_THREAD_SAFE_METHOD_ _THREAD_SAFE_METHOD_
HashMap<DisplayServer::WindowID, RDD::SwapChainID>::ConstIterator it = screen_swap_chains.find(p_screen); HashMap<DisplayServer::WindowID, RDD::SwapChainID>::ConstIterator it = screen_swap_chains.find(p_screen);
ERR_FAIL_COND_V_MSG(it == screen_swap_chains.end(), FAILED, "Screen was never prepared."); ERR_FAIL_COND_V_MSG(it == screen_swap_chains.end(), INVALID_ID, "Screen was never prepared.");
DataFormat format = driver->swap_chain_get_format(it->value); DataFormat format = driver->swap_chain_get_format(it->value);
ERR_FAIL_COND_V(format == DATA_FORMAT_MAX, INVALID_ID); ERR_FAIL_COND_V(format == DATA_FORMAT_MAX, INVALID_ID);