godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-05 12:10:55 +00:00
Code Releases Wiki Activity

Editor: Fix invalid use of Node::get_viewport() after rename of EditorNode::get_viewport()

Browse Source 
Fixes #44761, was a regression from #44524.

The PR passed CI because EditorNode::get_viewport() used to shadow Node::get_viewport()
(which was a bug in itself, fixed by #44524), so once it was renamed the existing code
relying on it fell back to the now available Node::get_viewport().
This might bite some thirdparty modules too.
This commit is contained in:
Rémi Verschelde
2020-12-28 19:51:39 +01:00
parent a04b9669e8
commit 44357ddc28
14 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
editor/plugins/mesh_instance_3d_editor_plugin.cpp
View File

@@ -505,7 +505,7 @@ void MeshInstance3DEditorPlugin::make_visible(bool p_visible) {
MeshInstance3DEditorPlugin::MeshInstance3DEditorPlugin(EditorNode *p_node) {
editor = p_node;
mesh_editor = memnew(MeshInstance3DEditor);
editor->get_viewport()->add_child(mesh_editor);
editor->get_main_control()->add_child(mesh_editor);
mesh_editor->options->hide();
}