godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Merge pull request #107632 from gongpha/potentially-memory-leak

Browse Source 
Free nodes from instantiating if it is not a `Control` in the theme editor
This commit is contained in:
Thaddeus Crews
2025-06-18 18:14:07 -05:00
parent b0dc2b4e50 4067d7d30f
commit 3f99c09685
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
editor/plugins/theme_editor_preview.cpp
View File

@@ -510,8 +510,15 @@ bool SceneThemeEditorPreview::set_preview_scene(const String &p_path) {
} }
Node *instance = loaded_scene->instantiate(); Node *instance = loaded_scene->instantiate();
if (!instance || !Object::cast_to<Control>(instance)) {
if (!instance) {
EditorNode::get_singleton()->show_warning(TTR("Invalid PackedScene resource, could not instantiate it."));
return false;
}
if (!Object::cast_to<Control>(instance)) {
EditorNode::get_singleton()->show_warning(TTR("Invalid PackedScene resource, must have a Control node at its root.")); EditorNode::get_singleton()->show_warning(TTR("Invalid PackedScene resource, must have a Control node at its root."));
memdelete(instance);
return false; return false;
} }