godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Merge pull request #109006 from RoyBerardo/random_pitch_bias_fix

Browse Source 
Fix random pitch upward bias in `AudioStreamRandomizer`
This commit is contained in:
Thaddeus Crews
2025-08-03 10:51:11 -05:00
parent 0d6c1c37e2 3e01c8a551
commit 38f8e18303
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
servers/audio/audio_stream.cpp
View File

@@ -799,10 +799,13 @@ AudioStreamRandomizer::AudioStreamRandomizer() {
void AudioStreamPlaybackRandomizer::start(double p_from_pos) { void AudioStreamPlaybackRandomizer::start(double p_from_pos) {
playing = playback; playing = playback;
{ {
float range_from = 1.0 / randomizer->random_pitch_scale; // GH-10238 : Pitch_scale is multiplicative, so picking a random number for it without log
float range_to = randomizer->random_pitch_scale; // conversion will bias it towards higher pitches (0.5 is down one octave, 2.0 is up one octave).
// See: https://pressbooks.pub/sound/chapter/pitch-and-frequency-in-music/
float range_from = Math::log(1.0f / randomizer->random_pitch_scale);
float range_to = Math::log(randomizer->random_pitch_scale);
pitch_scale = range_from + Math::randf() * (range_to - range_from); pitch_scale = Math::exp(range_from + Math::randf() * (range_to - range_from));
} }
{ {
float range_from = -randomizer->random_volume_offset_db; float range_from = -randomizer->random_volume_offset_db;