godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-10 13:00:37 +00:00
Code Releases Wiki Activity

Fix seed not randomizing for particles. Fix seed being stored when fixed seed is off

Browse Source
This commit is contained in:
Qbieshay
2025-02-04 11:51:17 +01:00
parent 1586c5674b
commit 2f3f6f69d9
4 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
scene/2d/cpu_particles_2d.cpp
View File

@@ -597,7 +597,7 @@ void CPUParticles2D::_validate_property(PropertyInfo &p_property) const {
} }
if (p_property.name == "seed" && !use_fixed_seed) { if (p_property.name == "seed" && !use_fixed_seed) {
p_property.usage = PROPERTY_USAGE_NO_EDITOR; p_property.usage = PROPERTY_USAGE_NONE;
} }
} }
@@ -1392,6 +1392,8 @@ void CPUParticles2D::_bind_methods() {
BIND_ENUM_CONSTANT(DRAW_ORDER_INDEX); BIND_ENUM_CONSTANT(DRAW_ORDER_INDEX);
BIND_ENUM_CONSTANT(DRAW_ORDER_LIFETIME); BIND_ENUM_CONSTANT(DRAW_ORDER_LIFETIME);
ADD_PROPERTY_DEFAULT("seed", 0);
//////////////////////////////// ////////////////////////////////
ClassDB::bind_method(D_METHOD("set_direction", "direction"), &CPUParticles2D::set_direction); ClassDB::bind_method(D_METHOD("set_direction", "direction"), &CPUParticles2D::set_direction);
@@ -1561,6 +1563,7 @@ CPUParticles2D::CPUParticles2D() {
set_emitting(true); set_emitting(true);
set_amount(8); set_amount(8);
set_use_local_coordinates(false); set_use_local_coordinates(false);
set_seed(Math::rand());
rng.instantiate(); rng.instantiate();

6
scene/2d/gpu_particles_2d.cpp
View File

@@ -408,7 +408,7 @@ Ref<Texture2D> GPUParticles2D::get_texture() const {
void GPUParticles2D::_validate_property(PropertyInfo &p_property) const { void GPUParticles2D::_validate_property(PropertyInfo &p_property) const {
if (p_property.name == "seed" && !use_fixed_seed) { if (p_property.name == "seed" && !use_fixed_seed) {
p_property.usage = PROPERTY_USAGE_NO_EDITOR; p_property.usage = PROPERTY_USAGE_NONE;
} }
if (p_property.name == "emitting") { if (p_property.name == "emitting") {
p_property.hint = one_shot ? PROPERTY_HINT_ONESHOT : PROPERTY_HINT_NONE; p_property.hint = one_shot ? PROPERTY_HINT_ONESHOT : PROPERTY_HINT_NONE;
@@ -899,6 +899,8 @@ void GPUParticles2D::_bind_methods() {
BIND_ENUM_CONSTANT(EMIT_FLAG_VELOCITY); BIND_ENUM_CONSTANT(EMIT_FLAG_VELOCITY);
BIND_ENUM_CONSTANT(EMIT_FLAG_COLOR); BIND_ENUM_CONSTANT(EMIT_FLAG_COLOR);
BIND_ENUM_CONSTANT(EMIT_FLAG_CUSTOM); BIND_ENUM_CONSTANT(EMIT_FLAG_CUSTOM);
ADD_PROPERTY_DEFAULT("seed", 0);
} }
GPUParticles2D::GPUParticles2D() { GPUParticles2D::GPUParticles2D() {
@@ -912,8 +914,8 @@ GPUParticles2D::GPUParticles2D() {
one_shot = false; // Needed so that set_emitting doesn't access uninitialized values one_shot = false; // Needed so that set_emitting doesn't access uninitialized values
set_emitting(true); set_emitting(true);
set_one_shot(false); set_one_shot(false);
set_seed(Math::rand());
set_use_fixed_seed(false); set_use_fixed_seed(false);
set_seed(0);
set_amount(8); set_amount(8);
set_amount_ratio(1.0); set_amount_ratio(1.0);
set_lifetime(1); set_lifetime(1);

5
scene/3d/cpu_particles_3d.cpp
View File

@@ -612,7 +612,7 @@ void CPUParticles3D::_validate_property(PropertyInfo &p_property) const {
} }
if (p_property.name == "seed" && !use_fixed_seed) { if (p_property.name == "seed" && !use_fixed_seed) {
p_property.usage = PROPERTY_USAGE_NO_EDITOR; p_property.usage = PROPERTY_USAGE_NONE;
} }
} }
@@ -1564,6 +1564,8 @@ void CPUParticles3D::_bind_methods() {
BIND_ENUM_CONSTANT(DRAW_ORDER_LIFETIME); BIND_ENUM_CONSTANT(DRAW_ORDER_LIFETIME);
BIND_ENUM_CONSTANT(DRAW_ORDER_VIEW_DEPTH); BIND_ENUM_CONSTANT(DRAW_ORDER_VIEW_DEPTH);
ADD_PROPERTY_DEFAULT("seed", 0);
//////////////////////////////// ////////////////////////////////
ClassDB::bind_method(D_METHOD("set_direction", "direction"), &CPUParticles3D::set_direction); ClassDB::bind_method(D_METHOD("set_direction", "direction"), &CPUParticles3D::set_direction);
@@ -1764,6 +1766,7 @@ CPUParticles3D::CPUParticles3D() {
set_emitting(true); set_emitting(true);
set_amount(8); set_amount(8);
set_seed(Math::rand());
rng.instantiate(); rng.instantiate();

6
scene/3d/gpu_particles_3d.cpp
View File

@@ -464,7 +464,7 @@ void GPUParticles3D::_validate_property(PropertyInfo &p_property) const {
} }
} }
if (p_property.name == "seed" && !use_fixed_seed) { if (p_property.name == "seed" && !use_fixed_seed) {
p_property.usage = PROPERTY_USAGE_NO_EDITOR; p_property.usage = PROPERTY_USAGE_NONE;
} }
} }
@@ -868,6 +868,8 @@ void GPUParticles3D::_bind_methods() {
BIND_ENUM_CONSTANT(TRANSFORM_ALIGN_Z_BILLBOARD); BIND_ENUM_CONSTANT(TRANSFORM_ALIGN_Z_BILLBOARD);
BIND_ENUM_CONSTANT(TRANSFORM_ALIGN_Y_TO_VELOCITY); BIND_ENUM_CONSTANT(TRANSFORM_ALIGN_Y_TO_VELOCITY);
BIND_ENUM_CONSTANT(TRANSFORM_ALIGN_Z_BILLBOARD_Y_TO_VELOCITY); BIND_ENUM_CONSTANT(TRANSFORM_ALIGN_Z_BILLBOARD_Y_TO_VELOCITY);
ADD_PROPERTY_DEFAULT("seed", 0);
} }
GPUParticles3D::GPUParticles3D() { GPUParticles3D::GPUParticles3D() {
@@ -877,6 +879,7 @@ GPUParticles3D::GPUParticles3D() {
one_shot = false; // Needed so that set_emitting doesn't access uninitialized values one_shot = false; // Needed so that set_emitting doesn't access uninitialized values
set_emitting(true); set_emitting(true);
set_one_shot(false); set_one_shot(false);
set_seed(Math::rand());
set_amount_ratio(1.0); set_amount_ratio(1.0);
set_amount(8); set_amount(8);
set_lifetime(1); set_lifetime(1);
@@ -895,7 +898,6 @@ GPUParticles3D::GPUParticles3D() {
set_collision_base_size(collision_base_size); set_collision_base_size(collision_base_size);
set_transform_align(TRANSFORM_ALIGN_DISABLED); set_transform_align(TRANSFORM_ALIGN_DISABLED);
set_use_fixed_seed(false); set_use_fixed_seed(false);
set_seed(0);
} }
GPUParticles3D::~GPUParticles3D() { GPUParticles3D::~GPUParticles3D() {