godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-15 13:51:40 +00:00
Code Releases Wiki Activity

GDScriptParser - don't use index operator on linked list

Browse Source 
Index operators are super slow with linked lists. This came up in profiling the parsing, iterating sequentially using iterator is much faster.

(cherry picked from commit ef914dac31)
This commit is contained in:
lawnjelly
2023-03-11 17:05:12 +00:00
committed by Rémi Verschelde
parent 891b17d5db
commit 2e8e7b8b79
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/gdscript/gdscript_parser.cpp
View File

@@ -8592,8 +8592,8 @@ void GDScriptParser::_check_block_types(BlockNode *p_block) {
}
// Parse sub blocks
for (int i = 0; i < p_block->sub_blocks.size(); i++) {
current_block = p_block->sub_blocks[i];
for (const List<BlockNode *>::Element *E = p_block->sub_blocks.front(); E; E = E->next()) {
current_block = E->get();
_check_block_types(current_block);
current_block = p_block;
if (error_set) {