From f82b4fdf7a7157db5c5635b06c076756e8b6ac8a Mon Sep 17 00:00:00 2001
From: arkology <43543909+arkology@users.noreply.github.com>
Date: Sun, 14 Dec 2025 12:25:41 +0300
Subject: [PATCH] Fix unique button for `EditorAudioStreamPicker`

Separate logic for `make_unique_button` and `assign_button` in `EditorResourcePicker::_update_resource()`
---
 editor/inspector/editor_resource_picker.cpp | 105 ++++++++++----------
 1 file changed, 54 insertions(+), 51 deletions(-)

diff --git a/editor/inspector/editor_resource_picker.cpp b/editor/inspector/editor_resource_picker.cpp
index 8dc231c6ffc..aa299d8741d 100644
--- a/editor/inspector/editor_resource_picker.cpp
+++ b/editor/inspector/editor_resource_picker.cpp
@@ -94,58 +94,7 @@ void EditorResourcePicker::_update_resource() {
 			assign_button->set_button_icon(Ref<Texture2D>());
 			assign_button->set_text(TTR("<empty>"));
 			assign_button->set_tooltip_text("");
-			make_unique_button->set_disabled(true);
-			make_unique_button->set_visible(false);
 		} else {
-			Ref<Resource> parent_res = _has_parent_resource();
-			bool unique_enable = _is_uniqueness_enabled();
-			bool unique_recursive_enabled = _is_uniqueness_enabled(true);
-			bool is_internal = EditorNode::get_singleton()->is_resource_internal_to_scene(edited_resource);
-			int num_of_copies = EditorNode::get_singleton()->get_resource_count(edited_resource);
-			make_unique_button->set_button_icon(get_editor_theme_icon(SNAME("Instance")));
-			make_unique_button->set_visible((num_of_copies > 1 || !is_internal) && !Object::cast_to<Script>(edited_resource.ptr()));
-			make_unique_button->set_disabled((!unique_enable && !unique_recursive_enabled) || !editable);
-
-			String tooltip;
-
-			String resource_name = "resource";
-			if (edited_resource.is_valid()) {
-				resource_name = edited_resource->get_class();
-
-				if (edited_resource->has_meta(SceneStringName(_custom_type_script))) {
-					const Ref<Script> custom_script = PropertyUtils::get_custom_type_script(edited_resource.ptr());
-					if (custom_script.is_valid()) {
-						const String global_name = custom_script->get_global_name();
-						if (!global_name.is_empty()) {
-							resource_name = global_name;
-						}
-					}
-				}
-			}
-
-			if (num_of_copies > 1) {
-				tooltip = vformat(TTRN("This %s is used in %d place.", "This %s is used in %d places.", num_of_copies), resource_name, num_of_copies);
-			} else if (!is_internal) {
-				tooltip = vformat(TTR("This %s is external to scene."), resource_name);
-			}
-
-			if (!editable) {
-				tooltip += "\n" + vformat(TTR("The %s cannot be edited in the inspector and can't be made unique directly."), resource_name) + "\n";
-			} else {
-				if (unique_enable) {
-					tooltip += "\n" + TTR("Left-click to make it unique.") + "\n";
-				}
-
-				if (unique_recursive_enabled) {
-					tooltip += TTR("It is possible to make its subresources unique.") + "\n" + TTR("Right-click to make them unique.");
-				}
-
-				if (!unique_enable && EditorNode::get_singleton()->get_editor_selection()->get_full_selected_node_list().size() == 1) {
-					tooltip += TTR("In order to duplicate it, make its parent Resource unique.") + "\n";
-				}
-			}
-
-			make_unique_button->set_tooltip_text(tooltip);
 			assign_button->set_button_icon(EditorNode::get_singleton()->get_object_icon(edited_resource.operator->()));
 
 			if (!edited_resource->get_name().is_empty()) {
@@ -168,6 +117,60 @@ void EditorResourcePicker::_update_resource() {
 		assign_button->set_tooltip_text(resource_path + TTR("Type:") + " " + edited_resource->get_class());
 	}
 
+	if (edited_resource.is_null()) {
+		make_unique_button->set_visible(false);
+	} else {
+		Ref<Resource> parent_res = _has_parent_resource();
+		bool unique_enable = _is_uniqueness_enabled();
+		bool unique_recursive_enabled = _is_uniqueness_enabled(true);
+		bool is_internal = EditorNode::get_singleton()->is_resource_internal_to_scene(edited_resource);
+		int num_of_copies = EditorNode::get_singleton()->get_resource_count(edited_resource);
+		make_unique_button->set_button_icon(get_editor_theme_icon(SNAME("Instance")));
+		make_unique_button->set_visible((num_of_copies > 1 || !is_internal) && !Object::cast_to<Script>(edited_resource.ptr()));
+		make_unique_button->set_disabled((!unique_enable && !unique_recursive_enabled) || !editable);
+
+		String tooltip;
+
+		String resource_name = "resource";
+		if (edited_resource.is_valid()) {
+			resource_name = edited_resource->get_class();
+
+			if (edited_resource->has_meta(SceneStringName(_custom_type_script))) {
+				const Ref<Script> custom_script = PropertyUtils::get_custom_type_script(edited_resource.ptr());
+				if (custom_script.is_valid()) {
+					const String global_name = custom_script->get_global_name();
+					if (!global_name.is_empty()) {
+						resource_name = global_name;
+					}
+				}
+			}
+		}
+
+		if (num_of_copies > 1) {
+			tooltip = vformat(TTRN("This %s is used in %d place.", "This %s is used in %d places.", num_of_copies), resource_name, num_of_copies);
+		} else if (!is_internal) {
+			tooltip = vformat(TTR("This %s is external to scene."), resource_name);
+		}
+
+		if (!editable) {
+			tooltip += "\n" + vformat(TTR("The %s cannot be edited in the inspector and can't be made unique directly."), resource_name) + "\n";
+		} else {
+			if (unique_enable) {
+				tooltip += "\n" + TTR("Left-click to make it unique.") + "\n";
+			}
+
+			if (unique_recursive_enabled) {
+				tooltip += TTR("It is possible to make its subresources unique.") + "\n" + TTR("Right-click to make them unique.");
+			}
+
+			if (!unique_enable && EditorNode::get_singleton()->get_editor_selection()->get_full_selected_node_list().size() == 1) {
+				tooltip += TTR("In order to duplicate it, make its parent Resource unique.") + "\n";
+			}
+		}
+
+		make_unique_button->set_tooltip_text(tooltip);
+	}
+
 	assign_button->set_disabled(!editable && edited_resource.is_null());
 	quick_load_button->set_visible(editable && edited_resource.is_null());
 }