godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Improve line BiDi handling, prevent crash on recursive log updates.

Browse Source
This commit is contained in:
bruvzg
2023-04-12 11:39:05 +03:00
parent 1433c98e9f
commit 282e4231c2
5 changed files with 54 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
editor/editor_log.cpp
View File

@@ -276,6 +276,11 @@ void EditorLog::_add_log_line(LogMessage &p_message, bool p_replace_previous) {
return;
}
if (unlikely(log->is_updating())) {
// The new message arrived during log RTL text processing/redraw (invalid BiDi control characters / font error), ignore it to avoid RTL data corruption.
return;
}
// Only add the message to the log if it passes the filters.
bool filter_active = type_filter_map[p_message.type]->is_active();
String search_text = search_box->get_text();