godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-07 12:30:27 +00:00
Code Releases Wiki Activity

Remove unimplemented Environment.ambient_light_occlusion_color property

Browse Source 
This property was intended to provide a way to have SSAO or VoxelGI
ambient occlusion with a color other than black. However, it was
dropped during the Vulkan renderer development due to the performance
overhead it caused when the feature wasn't used.
This commit is contained in:
Hugo Locurcio
2021-10-07 15:01:14 +02:00
parent 8afd2171d1
commit 265bae824f
24 changed files with 16 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
servers/rendering/renderer_rd/renderer_scene_gi_rd.cpp
View File

@@ -3121,7 +3121,6 @@ void RendererSceneGIRD::process_gi(RID p_render_buffers, RID p_normal_roughness_
RendererSceneRenderRD::RenderBuffers *rb = p_scene_render->render_buffers_owner.get_or_null(p_render_buffers);
ERR_FAIL_COND(rb == nullptr);
RendererSceneEnvironmentRD *env = p_scene_render->environment_owner.get_or_null(p_environment);
if (rb->ambient_buffer.is_null() || rb->gi.using_half_size_gi != half_resolution) {
if (rb->ambient_buffer.is_valid()) {
@@ -3160,16 +3159,6 @@ void RendererSceneGIRD::process_gi(RID p_render_buffers, RID p_normal_roughness_
bool use_sdfgi = rb->sdfgi != nullptr;
bool use_voxel_gi_instances = push_constant.max_voxel_gi_instances > 0;
if (env) {
push_constant.ao_color[0] = env->ao_color.r;
push_constant.ao_color[1] = env->ao_color.g;
push_constant.ao_color[2] = env->ao_color.b;
} else {
push_constant.ao_color[0] = 0;
push_constant.ao_color[1] = 0;
push_constant.ao_color[2] = 0;
}
push_constant.cam_rotation[0] = p_transform.basis[0][0];
push_constant.cam_rotation[1] = p_transform.basis[1][0];
push_constant.cam_rotation[2] = p_transform.basis[2][0];