godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Fix occlusion culling by using depth instead of Euclidean distance when selecting the closest point

Browse Source 
Co-authored-by: Florent Guiocheau <florent.guiocheau@gmail.com>
This commit is contained in:
Rudolph Bester
2024-10-01 20:04:21 +02:00
committed by Rudolph Bester
parent b5bdb88062
commit 18eb1c1072
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
modules/raycast/raycast_occlusion_cull.cpp
View File

@@ -173,7 +173,9 @@ void RaycastOcclusionCull::RaycastHZBuffer::sort_rays(const Vector3 &p_camera_di
}
int k = tile_i * TILE_SIZE + tile_j;
int tile_index = i * tile_grid_size.x + j;
mips[0][y * buffer_size.x + x] = camera_rays[tile_index].ray.tfar[k];
Vector3 ray_dir(camera_rays[tile_index].ray.dir_x[k], camera_rays[tile_index].ray.dir_y[k], camera_rays[tile_index].ray.dir_z[k]);
mips[0][y * buffer_size.x + x] = camera_rays[tile_index].ray.tfar[k] * p_camera_dir.dot(ray_dir); // Store z-depth in view space.
}
}
}

7
servers/rendering/renderer_scene_occlusion_cull.h
View File

@@ -71,7 +71,7 @@ public:
return false;
}
float min_depth = (closest_point - p_cam_position).length();
float min_depth = -closest_point_view.z;
Vector2 rect_min = Vector2(FLT_MAX, FLT_MAX);
Vector2 rect_max = Vector2(FLT_MIN, FLT_MIN);
@@ -82,12 +82,9 @@ public:
Vector3 corner = Vector3(p_bounds[0] * c.x + p_bounds[3] * nc.x, p_bounds[1] * c.y + p_bounds[4] * nc.y, p_bounds[2] * c.z + p_bounds[5] * nc.z);
Vector3 view = p_cam_inv_transform.xform(corner);
if (p_cam_projection.is_orthogonal()) {
min_depth = MIN(min_depth, -view.z);
}
Plane vp = Plane(view, 1.0);
Plane projected = p_cam_projection.xform4(vp);
min_depth = MIN(min_depth, -view.z);
float w = projected.d;
if (w < 1.0) {