godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-12-03 16:55:53 +00:00
Code Releases Wiki Activity

VCS: Fix GDExtension return types for VCS after Array type hardening

Browse Source
This commit is contained in:
Twarit Waikar
2022-12-20 15:36:14 +05:30
parent dcb3754db0
commit 18df2f36e8
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
doc/classes/EditorVCSInterface.xml
View File

@@ -53,7 +53,7 @@
</description> </description>
</method> </method>
<method name="_get_branch_list" qualifiers="virtual"> <method name="_get_branch_list" qualifiers="virtual">
<return type="Dictionary[]" /> <return type="String[]" />
<description> <description>
Gets an instance of an [Array] of [String]s containing available branch names in the VCS. Gets an instance of an [Array] of [String]s containing available branch names in the VCS.
</description> </description>
@@ -94,7 +94,7 @@
</description> </description>
</method> </method>
<method name="_get_remotes" qualifiers="virtual"> <method name="_get_remotes" qualifiers="virtual">
<return type="Dictionary[]" /> <return type="String[]" />
<description> <description>
Returns an [Array] of [String]s, each containing the name of a remote configured in the VCS. Returns an [Array] of [String]s, each containing the name of a remote configured in the VCS.
</description> </description>

4
editor/editor_vcs_interface.cpp
View File

@@ -57,7 +57,7 @@ void EditorVCSInterface::set_credentials(String p_username, String p_password, S
} }
List<String> EditorVCSInterface::get_remotes() { List<String> EditorVCSInterface::get_remotes() {
TypedArray<Dictionary> result; TypedArray<String> result;
if (!GDVIRTUAL_CALL(_get_remotes, result)) { if (!GDVIRTUAL_CALL(_get_remotes, result)) {
UNIMPLEMENTED(); UNIMPLEMENTED();
return {}; return {};
@@ -137,7 +137,7 @@ List<EditorVCSInterface::Commit> EditorVCSInterface::get_previous_commits(int p_
} }
List<String> EditorVCSInterface::get_branch_list() { List<String> EditorVCSInterface::get_branch_list() {
TypedArray<Dictionary> result; TypedArray<String> result;
if (!GDVIRTUAL_CALL(_get_branch_list, result)) { if (!GDVIRTUAL_CALL(_get_branch_list, result)) {
UNIMPLEMENTED(); UNIMPLEMENTED();
return {}; return {};

4
editor/editor_vcs_interface.h
View File

@@ -117,8 +117,8 @@ protected:
GDVIRTUAL0R(bool, _shut_down); GDVIRTUAL0R(bool, _shut_down);
GDVIRTUAL0R(String, _get_vcs_name); GDVIRTUAL0R(String, _get_vcs_name);
GDVIRTUAL1R(TypedArray<Dictionary>, _get_previous_commits, int); GDVIRTUAL1R(TypedArray<Dictionary>, _get_previous_commits, int);
GDVIRTUAL0R(TypedArray<Dictionary>, _get_branch_list); GDVIRTUAL0R(TypedArray<String>, _get_branch_list);
GDVIRTUAL0R(TypedArray<Dictionary>, _get_remotes); GDVIRTUAL0R(TypedArray<String>, _get_remotes);
GDVIRTUAL1(_create_branch, String); GDVIRTUAL1(_create_branch, String);
GDVIRTUAL1(_remove_branch, String); GDVIRTUAL1(_remove_branch, String);
GDVIRTUAL2(_create_remote, String, String); GDVIRTUAL2(_create_remote, String, String);