godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-08 12:40:44 +00:00
Code Releases Wiki Activity

[fbx] Fix #44371 #44376 File crash and Buffer Overflow

Browse Source 
Fixes:
- Element collection will only contain valid elements.
- Fixes buffer overflow in the FBX document
This commit is contained in:
Gordon MacPherson
2020-12-14 21:42:01 +00:00
parent ee903becc8
commit 18d1898309
4 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/fbx/fbx_parser/FBXMeshGeometry.cpp
View File

@@ -182,7 +182,7 @@ MeshGeometry::MeshGeometry(uint64_t id, const ElementPtr element, const std::str
// This is stupid, because it means we select them ALL not just the one we want.
// but it's fine we can match by id.
GetRequiredElement(top, layer_type_name);
const ElementCollection &candidates = top->GetCollection(layer_type_name);
ElementMap::const_iterator iter;