You've already forked godot
mirror of
https://github.com/godotengine/godot.git
synced 2025-11-05 12:10:55 +00:00
Cleanup C# projects, code quality & style
New rules: - Do not silence CA1805 any more - Limit where we silence CA1707, CA1711, CA1720 - Enforce severity=warning for IDE0040 - Enforce Allman style braces - Enforce naming conventions (IDE1006 is still severity=suggestion) Fixes: - Fix REFL045, CS1572, CS1573 - Suppress CS0618 when generating `InvokeGodotClassMethod` - Fix indent when generating GD_constants.cs - Temporarily silence CS1734 in generated code - Fix a lot of naming rule violations Misc.: - Remove ReSharper comments for RedundantNameQualifier - Remove suppression attributes for RedundantNameQualifier - Remove severity=warnings for CA1716, CA1304 (already included in the level of analysis we run)
This commit is contained in:
Paul Joannon
@@ -13,106 +13,106 @@ namespace Godot.SourceGenerators.Sample
|
||||
[SuppressMessage("ReSharper", "InconsistentNaming")]
|
||||
public partial class ExportedFields : GodotObject
|
||||
{
|
||||
[Export] private Boolean field_Boolean = true;
|
||||
[Export] private Char field_Char = 'f';
|
||||
[Export] private SByte field_SByte = 10;
|
||||
[Export] private Int16 field_Int16 = 10;
|
||||
[Export] private Int32 field_Int32 = 10;
|
||||
[Export] private Int64 field_Int64 = 10;
|
||||
[Export] private Byte field_Byte = 10;
|
||||
[Export] private UInt16 field_UInt16 = 10;
|
||||
[Export] private UInt32 field_UInt32 = 10;
|
||||
[Export] private UInt64 field_UInt64 = 10;
|
||||
[Export] private Single field_Single = 10;
|
||||
[Export] private Double field_Double = 10;
|
||||
[Export] private String field_String = "foo";
|
||||
[Export] private Boolean _fieldBoolean = true;
|
||||
[Export] private Char _fieldChar = 'f';
|
||||
[Export] private SByte _fieldSByte = 10;
|
||||
[Export] private Int16 _fieldInt16 = 10;
|
||||
[Export] private Int32 _fieldInt32 = 10;
|
||||
[Export] private Int64 _fieldInt64 = 10;
|
||||
[Export] private Byte _fieldByte = 10;
|
||||
[Export] private UInt16 _fieldUInt16 = 10;
|
||||
[Export] private UInt32 _fieldUInt32 = 10;
|
||||
[Export] private UInt64 _fieldUInt64 = 10;
|
||||
[Export] private Single _fieldSingle = 10;
|
||||
[Export] private Double _fieldDouble = 10;
|
||||
[Export] private String _fieldString = "foo";
|
||||
|
||||
// Godot structs
|
||||
[Export] private Vector2 field_Vector2 = new(10f, 10f);
|
||||
[Export] private Vector2I field_Vector2I = Vector2I.Up;
|
||||
[Export] private Rect2 field_Rect2 = new(new Vector2(10f, 10f), new Vector2(10f, 10f));
|
||||
[Export] private Rect2I field_Rect2I = new(new Vector2I(10, 10), new Vector2I(10, 10));
|
||||
[Export] private Transform2D field_Transform2D = Transform2D.Identity;
|
||||
[Export] private Vector3 field_Vector3 = new(10f, 10f, 10f);
|
||||
[Export] private Vector3I field_Vector3I = Vector3I.Back;
|
||||
[Export] private Basis field_Basis = new Basis(Quaternion.Identity);
|
||||
[Export] private Quaternion field_Quaternion = new Quaternion(Basis.Identity);
|
||||
[Export] private Transform3D field_Transform3D = Transform3D.Identity;
|
||||
[Export] private Vector4 field_Vector4 = new(10f, 10f, 10f, 10f);
|
||||
[Export] private Vector4I field_Vector4I = Vector4I.One;
|
||||
[Export] private Projection field_Projection = Projection.Identity;
|
||||
[Export] private Aabb field_Aabb = new Aabb(10f, 10f, 10f, new Vector3(1f, 1f, 1f));
|
||||
[Export] private Color field_Color = Colors.Aquamarine;
|
||||
[Export] private Plane field_Plane = Plane.PlaneXZ;
|
||||
[Export] private Callable field_Callable = new Callable(Engine.GetMainLoop(), "_process");
|
||||
[Export] private Signal field_Signal = new Signal(Engine.GetMainLoop(), "property_list_changed");
|
||||
[Export] private Vector2 _fieldVector2 = new(10f, 10f);
|
||||
[Export] private Vector2I _fieldVector2I = Vector2I.Up;
|
||||
[Export] private Rect2 _fieldRect2 = new(new Vector2(10f, 10f), new Vector2(10f, 10f));
|
||||
[Export] private Rect2I _fieldRect2I = new(new Vector2I(10, 10), new Vector2I(10, 10));
|
||||
[Export] private Transform2D _fieldTransform2D = Transform2D.Identity;
|
||||
[Export] private Vector3 _fieldVector3 = new(10f, 10f, 10f);
|
||||
[Export] private Vector3I _fieldVector3I = Vector3I.Back;
|
||||
[Export] private Basis _fieldBasis = new Basis(Quaternion.Identity);
|
||||
[Export] private Quaternion _fieldQuaternion = new Quaternion(Basis.Identity);
|
||||
[Export] private Transform3D _fieldTransform3D = Transform3D.Identity;
|
||||
[Export] private Vector4 _fieldVector4 = new(10f, 10f, 10f, 10f);
|
||||
[Export] private Vector4I _fieldVector4I = Vector4I.One;
|
||||
[Export] private Projection _fieldProjection = Projection.Identity;
|
||||
[Export] private Aabb _fieldAabb = new Aabb(10f, 10f, 10f, new Vector3(1f, 1f, 1f));
|
||||
[Export] private Color _fieldColor = Colors.Aquamarine;
|
||||
[Export] private Plane _fieldPlane = Plane.PlaneXZ;
|
||||
[Export] private Callable _fieldCallable = new Callable(Engine.GetMainLoop(), "_process");
|
||||
[Export] private Signal _fieldSignal = new Signal(Engine.GetMainLoop(), "property_list_changed");
|
||||
|
||||
// Enums
|
||||
[SuppressMessage("ReSharper", "UnusedMember.Local")]
|
||||
enum MyEnum
|
||||
public enum MyEnum
|
||||
{
|
||||
A,
|
||||
B,
|
||||
C
|
||||
}
|
||||
|
||||
[Export] private MyEnum field_Enum = MyEnum.C;
|
||||
[Export] private MyEnum _fieldEnum = MyEnum.C;
|
||||
|
||||
[Flags]
|
||||
[SuppressMessage("ReSharper", "UnusedMember.Local")]
|
||||
enum MyFlagsEnum
|
||||
public enum MyFlagsEnum
|
||||
{
|
||||
A,
|
||||
B,
|
||||
C
|
||||
}
|
||||
|
||||
[Export] private MyFlagsEnum field_FlagsEnum = MyFlagsEnum.C;
|
||||
[Export] private MyFlagsEnum _fieldFlagsEnum = MyFlagsEnum.C;
|
||||
|
||||
// Arrays
|
||||
[Export] private Byte[] field_ByteArray = { 0, 1, 2, 3, 4, 5, 6 };
|
||||
[Export] private Int32[] field_Int32Array = { 0, 1, 2, 3, 4, 5, 6 };
|
||||
[Export] private Int64[] field_Int64Array = { 0, 1, 2, 3, 4, 5, 6 };
|
||||
[Export] private Single[] field_SingleArray = { 0f, 1f, 2f, 3f, 4f, 5f, 6f };
|
||||
[Export] private Double[] field_DoubleArray = { 0d, 1d, 2d, 3d, 4d, 5d, 6d };
|
||||
[Export] private String[] field_StringArray = { "foo", "bar" };
|
||||
[Export(PropertyHint.Enum, "A,B,C")] private String[] field_StringArrayEnum = { "foo", "bar" };
|
||||
[Export] private Vector2[] field_Vector2Array = { Vector2.Up, Vector2.Down, Vector2.Left, Vector2.Right };
|
||||
[Export] private Vector3[] field_Vector3Array = { Vector3.Up, Vector3.Down, Vector3.Left, Vector3.Right };
|
||||
[Export] private Color[] field_ColorArray = { Colors.Aqua, Colors.Aquamarine, Colors.Azure, Colors.Beige };
|
||||
[Export] private GodotObject[] field_GodotObjectOrDerivedArray = { null };
|
||||
[Export] private StringName[] field_StringNameArray = { "foo", "bar" };
|
||||
[Export] private NodePath[] field_NodePathArray = { "foo", "bar" };
|
||||
[Export] private Rid[] field_RidArray = { default, default, default };
|
||||
[Export] private Byte[] _fieldByteArray = { 0, 1, 2, 3, 4, 5, 6 };
|
||||
[Export] private Int32[] _fieldInt32Array = { 0, 1, 2, 3, 4, 5, 6 };
|
||||
[Export] private Int64[] _fieldInt64Array = { 0, 1, 2, 3, 4, 5, 6 };
|
||||
[Export] private Single[] _fieldSingleArray = { 0f, 1f, 2f, 3f, 4f, 5f, 6f };
|
||||
[Export] private Double[] _fieldDoubleArray = { 0d, 1d, 2d, 3d, 4d, 5d, 6d };
|
||||
[Export] private String[] _fieldStringArray = { "foo", "bar" };
|
||||
[Export(PropertyHint.Enum, "A,B,C")] private String[] _fieldStringArrayEnum = { "foo", "bar" };
|
||||
[Export] private Vector2[] _fieldVector2Array = { Vector2.Up, Vector2.Down, Vector2.Left, Vector2.Right };
|
||||
[Export] private Vector3[] _fieldVector3Array = { Vector3.Up, Vector3.Down, Vector3.Left, Vector3.Right };
|
||||
[Export] private Color[] _fieldColorArray = { Colors.Aqua, Colors.Aquamarine, Colors.Azure, Colors.Beige };
|
||||
[Export] private GodotObject[] _fieldGodotObjectOrDerivedArray = { null };
|
||||
[Export] private StringName[] _fieldStringNameArray = { "foo", "bar" };
|
||||
[Export] private NodePath[] _fieldNodePathArray = { "foo", "bar" };
|
||||
[Export] private Rid[] _fieldRidArray = { default, default, default };
|
||||
// Note we use Array and not System.Array. This tests the generated namespace qualification.
|
||||
[Export] private Int32[] field_empty_Int32Array = Array.Empty<Int32>();
|
||||
[Export] private Int32[] _fieldEmptyInt32Array = Array.Empty<Int32>();
|
||||
// Note we use List and not System.Collections.Generic.
|
||||
[Export] private int[] field_array_from_list = new List<int>(Array.Empty<int>()).ToArray();
|
||||
[Export] private int[] _fieldArrayFromList = new List<int>(Array.Empty<int>()).ToArray();
|
||||
|
||||
// Variant
|
||||
[Export] private Variant field_Variant = "foo";
|
||||
[Export] private Variant _fieldVariant = "foo";
|
||||
|
||||
// Classes
|
||||
[Export] private GodotObject field_GodotObjectOrDerived;
|
||||
[Export] private Godot.Texture field_GodotResourceTexture;
|
||||
[Export] private StringName field_StringName = new StringName("foo");
|
||||
[Export] private NodePath field_NodePath = new NodePath("foo");
|
||||
[Export] private Rid field_Rid;
|
||||
[Export] private GodotObject _fieldGodotObjectOrDerived;
|
||||
[Export] private Godot.Texture _fieldGodotResourceTexture;
|
||||
[Export] private StringName _fieldStringName = new StringName("foo");
|
||||
[Export] private NodePath _fieldNodePath = new NodePath("foo");
|
||||
[Export] private Rid _fieldRid;
|
||||
|
||||
[Export]
|
||||
private Godot.Collections.Dictionary field_GodotDictionary =
|
||||
private Godot.Collections.Dictionary _fieldGodotDictionary =
|
||||
new() { { "foo", 10 }, { Vector2.Up, Colors.Chocolate } };
|
||||
|
||||
[Export]
|
||||
private Godot.Collections.Array field_GodotArray =
|
||||
private Godot.Collections.Array _fieldGodotArray =
|
||||
new() { "foo", 10, Vector2.Up, Colors.Chocolate };
|
||||
|
||||
[Export]
|
||||
private Godot.Collections.Dictionary<string, bool> field_GodotGenericDictionary =
|
||||
private Godot.Collections.Dictionary<string, bool> _fieldGodotGenericDictionary =
|
||||
new() { { "foo", true }, { "bar", false } };
|
||||
|
||||
[Export]
|
||||
private Godot.Collections.Array<int> field_GodotGenericArray =
|
||||
private Godot.Collections.Array<int> _fieldGodotGenericArray =
|
||||
new() { 0, 1, 2, 3, 4, 5, 6 };
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user