godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-11 13:10:58 +00:00
Code Releases Wiki Activity

Codestyle: Don't use auto where not warranted

Browse Source 
We allow using auto for lambdas or complex macros where a return type
may change based on the parameters. But where the type is clear, we
should be explicit.

Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
This commit is contained in:
Rémi Verschelde
2023-09-07 14:39:57 +02:00
parent d6d8cb1a17
commit 11518665b7
6 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/servers/rendering/test_shader_preprocessor.h
View File

@@ -66,7 +66,7 @@ String remove_spaces(String &p_str) {
for (int n = 0; n < p_str.size(); n++) {
// These test cases only use ASCII.
auto c = static_cast<unsigned char>(p_str[n]);
unsigned char c = static_cast<unsigned char>(p_str[n]);
if (std::isblank(c)) {
has_removed = true;
} else {
@@ -92,7 +92,7 @@ String remove_spaces(String &p_str) {
String compact_spaces(String &p_str) {
Vector<String> lines = p_str.split("\n", false);
erase_all_empty(lines);
for (auto &line : lines) {
for (String &line : lines) {
line = remove_spaces(line);
}
return String("\n").join(lines);