godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Improve RPC Error messages

Browse Source 
Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
This commit is contained in:
Ryan
2025-03-06 19:37:06 -05:00
parent c2202d36c1
commit 0f870fd286
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
modules/multiplayer/scene_rpc_interface.cpp
View File

@@ -224,6 +224,18 @@ void SceneRPCInterface::process_rpc(int p_from, const uint8_t *p_packet, int p_p
_process_rpc(node, name_id, p_from, p_packet, packet_len, packet_min_size); _process_rpc(node, name_id, p_from, p_packet, packet_len, packet_min_size);
} }
static String _get_rpc_mode_string(MultiplayerAPI::RPCMode p_mode) {
switch (p_mode) {
case MultiplayerAPI::RPC_MODE_DISABLED:
return "disabled";
case MultiplayerAPI::RPC_MODE_ANY_PEER:
return "any_peer";
case MultiplayerAPI::RPC_MODE_AUTHORITY:
return "authority";
}
ERR_FAIL_V_MSG(String(), "Invalid RPC mode.");
}
void SceneRPCInterface::_process_rpc(Node *p_node, const uint16_t p_rpc_method_id, int p_from, const uint8_t *p_packet, int p_packet_len, int p_offset) { void SceneRPCInterface::_process_rpc(Node *p_node, const uint16_t p_rpc_method_id, int p_from, const uint8_t *p_packet, int p_packet_len, int p_offset) {
ERR_FAIL_COND_MSG(p_offset > p_packet_len, "Invalid packet received. Size too small."); ERR_FAIL_COND_MSG(p_offset > p_packet_len, "Invalid packet received. Size too small.");
@@ -245,7 +257,7 @@ void SceneRPCInterface::_process_rpc(Node *p_node, const uint16_t p_rpc_method_i
} break; } break;
} }
ERR_FAIL_COND_MSG(!can_call, "RPC '" + String(config.name) + "' is not allowed on node " + String(p_node->get_path()) + " from: " + itos(p_from) + ". Mode is " + itos((int)config.rpc_mode) + ", authority is " + itos(p_node->get_multiplayer_authority()) + "."); ERR_FAIL_COND_MSG(!can_call, "RPC '" + String(config.name) + "' is not allowed on node " + String(p_node->get_path()) + " from: " + itos(p_from) + ". Mode is \"" + _get_rpc_mode_string(config.rpc_mode) + "\", authority is " + itos(p_node->get_multiplayer_authority()) + ".");
int argc = 0; int argc = 0;