godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-09 12:50:35 +00:00
Code Releases Wiki Activity

Merge pull request #18533 from JFonS/fix_shader_compile

Browse Source 
Fix vector reduction in shader language
This commit is contained in:
Juan Linietsky
2018-05-07 14:30:44 -03:00
committed by GitHub
parent 8c30337565 5b50685b38
commit 0db4c576f1
2 changed files with 44 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
servers/visual/shader_language.cpp
View File

@@ -2207,6 +2207,37 @@ ShaderLanguage::DataType ShaderLanguage::get_scalar_type(DataType p_type) {
return scalar_types[p_type]; return scalar_types[p_type];
} }
int ShaderLanguage::get_cardinality(DataType p_type) {
static const int cardinality_table[] = {
0,
1,
2,
3,
4,
1,
2,
3,
4,
1,
2,
3,
4,
1,
2,
3,
4,
2,
3,
4,
1,
1,
1,
1,
};
return cardinality_table[p_type];
}
bool ShaderLanguage::_get_completable_identifier(BlockNode *p_block, CompletionType p_type, StringName &identifier) { bool ShaderLanguage::_get_completable_identifier(BlockNode *p_block, CompletionType p_type, StringName &identifier) {
identifier = StringName(); identifier = StringName();
@@ -3111,9 +3142,18 @@ ShaderLanguage::Node *ShaderLanguage::_reduce_expression(BlockNode *p_block, Sha
if (get_scalar_type(cn->datatype) == base) { if (get_scalar_type(cn->datatype) == base) {
for (int j = 0; j < cn->values.size(); j++) { int cardinality = get_cardinality(op->arguments[i]->get_datatype());
values.push_back(cn->values[j]); if (cn->values.size() == cardinality) {
}
for (int j = 0; j < cn->values.size(); j++) {
values.push_back(cn->values[j]);
}
} else if (cn->values.size() == 1) {
for (int j = 0; j < cardinality; j++) {
values.push_back(cn->values[0]);
}
} // else: should be filtered by the parser as it's an invalid constructor
} else if (get_scalar_type(cn->datatype) == cn->datatype) { } else if (get_scalar_type(cn->datatype) == cn->datatype) {
ConstantNode::Value v; ConstantNode::Value v;

1
servers/visual/shader_language.h
View File

@@ -533,6 +533,7 @@ public:
static bool convert_constant(ConstantNode *p_constant, DataType p_to_type, ConstantNode::Value *p_value = NULL); static bool convert_constant(ConstantNode *p_constant, DataType p_to_type, ConstantNode::Value *p_value = NULL);
static DataType get_scalar_type(DataType p_type); static DataType get_scalar_type(DataType p_type);
static int get_cardinality(DataType p_type);
static bool is_scalar_type(DataType p_type); static bool is_scalar_type(DataType p_type);
static bool is_sampler_type(DataType p_type); static bool is_sampler_type(DataType p_type);