You've already forked godot
mirror of
https://github.com/godotengine/godot.git
synced 2025-11-11 13:10:58 +00:00
Style: Enforce separation line between function definitions
I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
This commit is contained in:
@@ -771,6 +771,7 @@ Error DocData::load_classes(const String &p_dir) {
|
||||
|
||||
return OK;
|
||||
}
|
||||
|
||||
Error DocData::erase_classes(const String &p_dir) {
|
||||
Error err;
|
||||
DirAccessRef da = DirAccess::open(p_dir, &err);
|
||||
@@ -798,6 +799,7 @@ Error DocData::erase_classes(const String &p_dir) {
|
||||
|
||||
return OK;
|
||||
}
|
||||
|
||||
Error DocData::_load(Ref<XMLParser> parser) {
|
||||
Error err = OK;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user