godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Fix LSP completion crashing on scene-less scripts

Browse Source
This commit is contained in:
Francois Belair
2021-08-06 14:55:05 -04:00
parent 18c5d862e4
commit 070d634966
2 changed files with 22 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
modules/gdscript/language_server/gdscript_workspace.cpp
View File

@@ -523,22 +523,24 @@ void GDScriptWorkspace::completion(const lsp::CompletionParams &p_params, List<S
Array stack;
Node *current = nullptr;
stack.push_back(owner_scene_node);
if (owner_scene_node != nullptr) {
stack.push_back(owner_scene_node);
while (!stack.is_empty()) {
current = stack.pop_back();
Ref<GDScript> script = current->get_script();
if (script.is_valid() && script->get_path() == path) {
break;
}
for (int i = 0; i < current->get_child_count(); ++i) {
stack.push_back(current->get_child(i));
}
}
while (!stack.is_empty()) {
current = stack.pop_back();
Ref<GDScript> script = current->get_script();
if (script.is_valid() && script->get_path() == path) {
break;
if (!script.is_valid() || script->get_path() != path) {
current = owner_scene_node;
}
for (int i = 0; i < current->get_child_count(); ++i) {
stack.push_back(current->get_child(i));
}
}
Ref<GDScript> script = current->get_script();
if (!script.is_valid() || script->get_path() != path) {
current = owner_scene_node;
}
String code = parser->get_text_for_completion(p_params.position);