godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-28 16:07:14 +00:00
Code Releases Wiki Activity

Merge pull request #101350 from Calinou/path-draw-fewer-fish-bones

Browse Source 
Draw fewer fishbones to improve Path gizmo readability and performance
This commit is contained in:
Rémi Verschelde
2025-01-09 20:51:37 +01:00
parent 7d9f28cac3 13a1391e73
commit 06a6a0bcdb
3 changed files with 25 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
editor/plugins/path_3d_editor_plugin.cpp
View File

@@ -340,16 +340,19 @@ void Path3DGizmo::redraw() {
// Path3D as a ribbon. // Path3D as a ribbon.
ribbon_ptr[i] = p1; ribbon_ptr[i] = p1;
// Fish Bone. if (i % 4 == 0) {
const Vector3 p_left = p1 + (side + forward - up * 0.3) * 0.06; // Draw fish bone every 4 points to reduce visual noise and performance impact
const Vector3 p_right = p1 + (-side + forward - up * 0.3) * 0.06; // (compared to drawing it for every point).
const Vector3 p_left = p1 + (side + forward - up * 0.3) * 0.06;
const Vector3 p_right = p1 + (-side + forward - up * 0.3) * 0.06;
const int bone_idx = i * 4; const int bone_idx = i * 4;
bones_ptr[bone_idx] = p1; bones_ptr[bone_idx] = p1;
bones_ptr[bone_idx + 1] = p_left; bones_ptr[bone_idx + 1] = p_left;
bones_ptr[bone_idx + 2] = p1; bones_ptr[bone_idx + 2] = p1;
bones_ptr[bone_idx + 3] = p_right; bones_ptr[bone_idx + 3] = p_right;
}
} }
add_collision_segments(_collision_segments); add_collision_segments(_collision_segments);

5
scene/2d/path_2d.cpp
View File

@@ -138,13 +138,14 @@ void Path2D::_notification(int p_what) {
draw_polyline(v2p, get_tree()->get_debug_paths_color(), line_width, false); draw_polyline(v2p, get_tree()->get_debug_paths_color(), line_width, false);
} }
// Draw fish bones // Draw fish bone every 4 points to reduce visual noise and performance impact
// (compared to drawing it for every point).
{ {
PackedVector2Array v2p; PackedVector2Array v2p;
v2p.resize(3); v2p.resize(3);
Vector2 *w = v2p.ptrw(); Vector2 *w = v2p.ptrw();
for (int i = 0; i < sample_count; i++) { for (int i = 0; i < sample_count; i += 4) {
const Vector2 p = r[i].get_origin(); const Vector2 p = r[i].get_origin();
const Vector2 side = r[i].columns[1]; const Vector2 side = r[i].columns[1];
const Vector2 forward = r[i].columns[0]; const Vector2 forward = r[i].columns[0];

19
scene/3d/path_3d.cpp
View File

@@ -131,16 +131,19 @@ void Path3D::_update_debug_mesh() {
// Path3D as a ribbon. // Path3D as a ribbon.
ribbon_ptr[i] = p1; ribbon_ptr[i] = p1;
// Fish Bone. if (i % 4 == 0) {
const Vector3 p_left = p1 + (side + forward - up * 0.3) * 0.06; // Draw fish bone every 4 points to reduce visual noise and performance impact
const Vector3 p_right = p1 + (-side + forward - up * 0.3) * 0.06; // (compared to drawing it for every point).
const Vector3 p_left = p1 + (side + forward - up * 0.3) * 0.06;
const Vector3 p_right = p1 + (-side + forward - up * 0.3) * 0.06;
const int bone_idx = i * 4; const int bone_idx = i * 4;
bones_ptr[bone_idx] = p1; bones_ptr[bone_idx] = p1;
bones_ptr[bone_idx + 1] = p_left; bones_ptr[bone_idx + 1] = p_left;
bones_ptr[bone_idx + 2] = p1; bones_ptr[bone_idx + 2] = p1;
bones_ptr[bone_idx + 3] = p_right; bones_ptr[bone_idx + 3] = p_right;
}
} }
Array ribbon_array; Array ribbon_array;