godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-04 12:00:25 +00:00
Code Releases Wiki Activity

Fix ubsan reported errors in rendering

Browse Source 
This allows the TPS demo to run without an ubsan reports from any of the
rendering code.
This commit is contained in:
HP van Braam
2024-12-13 19:03:37 +01:00
parent 7f5c469292
commit 062d74bb9c
12 changed files with 81 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
servers/rendering/rendering_context_driver.h
View File

@@ -52,16 +52,20 @@ public:
void window_destroy(DisplayServer::WindowID p_window);
public:
enum Vendor {
VENDOR_UNKNOWN = 0x0,
VENDOR_AMD = 0x1002,
VENDOR_IMGTEC = 0x1010,
VENDOR_APPLE = 0x106B,
VENDOR_NVIDIA = 0x10DE,
VENDOR_ARM = 0x13B5,
VENDOR_MICROSOFT = 0x1414,
VENDOR_QUALCOMM = 0x5143,
VENDOR_INTEL = 0x8086
// Not an enum as these values are matched against values returned by
// the various drivers, which report them in uint32_t. Casting to an
// enum value is dangerous in this case as we don't actually know what
// range the driver is reporting a value in.
struct Vendor {
constexpr static uint32_t VENDOR_UNKNOWN = 0x0;
constexpr static uint32_t VENDOR_AMD = 0x1002;
constexpr static uint32_t VENDOR_IMGTEC = 0x1010;
constexpr static uint32_t VENDOR_APPLE = 0x106B;
constexpr static uint32_t VENDOR_NVIDIA = 0x10DE;
constexpr static uint32_t VENDOR_ARM = 0x13B5;
constexpr static uint32_t VENDOR_MICROSOFT = 0x1414;
constexpr static uint32_t VENDOR_QUALCOMM = 0x5143;
constexpr static uint32_t VENDOR_INTEL = 0x8086;
};
enum DeviceType {
@@ -79,7 +83,7 @@ public:
struct Device {
String name = "Unknown";
Vendor vendor = VENDOR_UNKNOWN;
uint32_t vendor = Vendor::VENDOR_UNKNOWN;
DeviceType type = DEVICE_TYPE_OTHER;
Workarounds workarounds;
};