godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-07 12:30:27 +00:00
Code Releases Wiki Activity

Merge pull request #96449 from Maran23/editor-help-scroll-fix

Browse Source 
Fix jumping to editor help does not scroll correctly sometimes
This commit is contained in:
Rémi Verschelde
2024-11-29 22:45:51 +01:00
parent 6d4bb8fbda af92685445
commit 05b80ae0a1
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
editor/editor_help.cpp
View File

@@ -2378,11 +2378,7 @@ void EditorHelp::_help_callback(const String &p_topic) {
} }
if (class_desc->is_finished()) { if (class_desc->is_finished()) {
// call_deferred() is not enough. class_desc->scroll_to_paragraph(line);
if (class_desc->is_connected(SceneStringName(draw), callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph))) {
class_desc->disconnect(SceneStringName(draw), callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph));
}
class_desc->connect(SceneStringName(draw), callable_mp(class_desc, &RichTextLabel::scroll_to_paragraph).bind(line), CONNECT_ONE_SHOT | CONNECT_DEFERRED);
} else { } else {
scroll_to = line; scroll_to = line;
} }

3
editor/plugins/script_editor_plugin.cpp
View File

@@ -3653,14 +3653,13 @@ void ScriptEditor::_help_class_goto(const String &p_desc) {
eh->set_name(cname); eh->set_name(cname);
tab_container->add_child(eh); tab_container->add_child(eh);
_go_to_tab(tab_container->get_tab_count() - 1);
eh->go_to_help(p_desc); eh->go_to_help(p_desc);
eh->connect("go_to_help", callable_mp(this, &ScriptEditor::_help_class_goto)); eh->connect("go_to_help", callable_mp(this, &ScriptEditor::_help_class_goto));
_add_recent_script(eh->get_class()); _add_recent_script(eh->get_class());
_sort_list_on_update = true; _sort_list_on_update = true;
_update_script_names(); _update_script_names();
_save_layout(); _save_layout();
callable_mp(this, &ScriptEditor::_help_tab_goto).call_deferred(cname, p_desc);
} }
bool ScriptEditor::_help_tab_goto(const String &p_name, const String &p_desc) { bool ScriptEditor::_help_tab_goto(const String &p_name, const String &p_desc) {