godotengine/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-11-19 14:31:59 +00:00
Code Releases Wiki Activity

Revert "Unify http- and percent- encode/decode"

Browse Source 
This reverts commit b76ee30917.
This commit is contained in:
Pedro J. Estébanez
2018-04-12 21:12:34 +02:00
parent 3a5b25d5b4
commit 00e98458ba
7 changed files with 110 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/io/http_client.cpp
View File

@@ -618,14 +618,14 @@ String HTTPClient::query_string_from_dict(const Dictionary &p_dict) {
String query = "";
Array keys = p_dict.keys();
for (int i = 0; i < keys.size(); ++i) {
String encoded_key = String(keys[i]).percent_encode();
String encoded_key = String(keys[i]).http_escape();
Variant value = p_dict[keys[i]];
switch (value.get_type()) {
case Variant::ARRAY: {
// Repeat the key with every values
Array values = value;
for (int j = 0; j < values.size(); ++j) {
query += "&" + encoded_key + "=" + String(values[j]).percent_encode();
query += "&" + encoded_key + "=" + String(values[j]).http_escape();
}
break;
}
@@ -636,7 +636,7 @@ String HTTPClient::query_string_from_dict(const Dictionary &p_dict) {
}
default: {
// Add the key-value pair
query += "&" + encoded_key + "=" + String(value).percent_encode();
query += "&" + encoded_key + "=" + String(value).http_escape();
}
}
}